Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for per feed webhook #3112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

misthios
Copy link

Did you follow the guidelines?

This PR adds support for webhooks on a per feed basis as well as a default webhook url which serves as a catch all: The old webhook url has been changed to act as the default webhook url which is used when there is none set for the feed. This also maintains backwards compatibility.

Renamed webhook integration settings:
image

New per feed webhook url field:
image

Solves/fixes:

Inspired by: #2039

Please note that all the webhooks share the same secret, this was done to keep the changes minimal.

information used in tests:

Only default webhook url set with multiple feeds (old behaviour):
image

This makes 1 request per feed, since i tested with 2 feeds i got 2 messages.

Feed with custom url:

Set custom url.
image

Webhook output.
image

Copy link
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase your pull-request to solve the merge conflicts. There is also some minor linter issues and missing translations that prevent the unit tests to pass.

internal/locale/translations/fr_FR.json Outdated Show resolved Hide resolved
internal/template/templates/views/edit_feed.html Outdated Show resolved Hide resolved
@misthios misthios marked this pull request as draft January 28, 2025 06:33
@misthios
Copy link
Author

I will rebase and fix the issues later today, draft until done

@misthios misthios marked this pull request as ready for review January 28, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants