Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MiniExcelDataReader): GetOrdinal always returns 0 #711

Merged
merged 1 commit into from
Jan 19, 2025
Merged

fix(MiniExcelDataReader): GetOrdinal always returns 0 #711

merged 1 commit into from
Jan 19, 2025

Conversation

izanhzh
Copy link
Member

@izanhzh izanhzh commented Jan 17, 2025 •
edited
Loading

fix #710

@shps951023 需要确认下是不是你 这个调整 误删除的，还是有其他的原因删除了 GetOrdinal 的重写

代码格式化工具导致单元测试文件有很多差异修改

@izanhzh izanhzh requested a review from shps951023 January 17, 2025 03:22
@shps951023 shps951023 merged commit 972663f into mini-software:master Jan 19, 2025
3 checks passed
@shps951023
Copy link
Member

shps951023 commented Jan 19, 2025 •
edited
Loading

@izanhzh 是我不小心删除，谢谢! 我添加单元测试避免之后同样情况

@izanhzh izanhzh deleted the fix-issue-710 branch January 20, 2025 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shps951023 shps951023 shps951023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataReader.GetOrdinal always returns 0
2 participants
@izanhzh @shps951023