Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new provider GIS #847

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Add new provider GIS #847

wants to merge 17 commits into from

Conversation

AlexGacon
Copy link

I am starting this new provider to gather all GIS (Geographical Information System) related nodes.

@AlexGacon
Copy link
Author

I also took the opportunity to update the contribution documentation in order to describe what must be done to add a new provider.

@AlexGacon
Copy link
Author

@mingrammer any chance to have it integrated?

Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small fixes:

  • rename the file gis/routing/osmr.png --- > should be osrm.png
  • gis/server/mapserver height is over 256, must be 256 max.
  • re-run autogen

@AlexGacon
Copy link
Author

@gabriel-tessier I just applied all your suggestions.

Copy link
Collaborator

@tvqphuoc01 tvqphuoc01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlexGacon can you help me check this website/static/img/resources/gis/server/geonetwork.png seem like this img is not match the size of our project. everything else is fine now 👍

@AlexGacon
Copy link
Author

@tvqphuoc01 hello! I just pushed the asked changes.

Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry again to asking changes.
I left copy paste comments...

  • There's files that are too big.
  • There's one file CAS in resources that is not related with nothing.
  • There's 2 certbot and openLdap that are not related with GIS.

Better to have only the changes for GIS provider in this PR.
You can open new PR for the on premise icons.

resources/cas.png Outdated Show resolved Hide resolved
resources/gis/cli/mdal.png Show resolved Hide resolved
resources/gis/desktop/maptunik.png Show resolved Hide resolved
resources/gis/geocoding/pelias.png Show resolved Hide resolved
resources/gis/mobile/smash.png Show resolved Hide resolved
resources/gis/server/kepler.png Show resolved Hide resolved
resources/gis/server/mapserver.png Show resolved Hide resolved
resources/onprem/certificates/certbot.png Outdated Show resolved Hide resolved
resources/openldap.png Outdated Show resolved Hide resolved
@gabriel-tessier
Copy link
Collaborator

@AlexGacon @tvqphuoc01

Just another comment, the icon mapnik is in the cplusplus section, what about move it to 'toolkit' that is more generic name.
As cplusplus is a language and if they rewrite it in Rust it will no more be correct.

I found the name 'toolkit' when I searched mapnik on wikipedia!

@AlexGacon
Copy link
Author

AlexGacon commented Jan 15, 2025 via email

@AlexGacon
Copy link
Author

@gabriel-tessier regarding mapnik, I have a folder "CLI" which can be seen as toolkit too. Should I rename it "toolkit" or move mapnik into "cli"?

@AlexGacon
Copy link
Author

@gabriel-tessier I just pushed the asked changes. It was in progress work I didn't track correctly. Sorry for the work.

@gabriel-tessier
Copy link
Collaborator

@gabriel-tessier regarding mapnik, I have a folder "CLI" which can be seen as toolkit too. Should I rename it "toolkit" or move mapnik into "cli"?

Let's put it 'cli' with other nodes.

Copy link
Collaborator

@gabriel-tessier gabriel-tessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexGacon
All good.
If you have time to move mapnik in 'cli' it's ok if you don't time it's will be also ok, it's not blocking.

I may ask you later an icon for GIS something like a global icon for the provider. It's related to this PR:
#1039

As you pushed a new documentation to add a provider I will update it with instruction to add a top icon for the provider.
I ask again but if it's ok for you I will assign you the issue, I will prepare it before the end of the month.

Thanks again for your contribution.

@AlexGacon
Copy link
Author

@gabriel-tessier changes done

@AlexGacon
Copy link
Author

@gabriel-tessier should I change something to pass the pre-commit check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feat/provider Provider request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants