-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Icon set for Oracle Cloud Services. #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
McSly
commented
Feb 16, 2020
- Add icon set for Oracle Cloud
- Update python scripts to handle the new provider
- Update documentation
- Update autogen.sh to use Image Magic instead of Inkscape to crop and resize and save the icons as PNG files as the current version of Inkscape is broken and can't export file to png
mingrammer
requested changes
Feb 16, 2020
+ Please resolve the conflicts |
Changes requested have been made |
"""
OCI provides a set of services for Oracle Cloud provider.
"""
from diagrams import Node
class _OCI(Node):
_provider = "oci"
_icon_dir = "resources/oci"
fontcolor = "#ffffff" |
mingrammer
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll release a new version soon.
Thank you for contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.