Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icon set for Oracle Cloud Services. #20

Merged
merged 11 commits into from
Feb 18, 2020
Merged

Conversation

McSly
Copy link
Contributor

@McSly McSly commented Feb 16, 2020

  • Add icon set for Oracle Cloud
  • Update python scripts to handle the new provider
  • Update documentation
  • Update autogen.sh to use Image Magic instead of Inkscape to crop and resize and save the icons as PNG files as the current version of Inkscape is broken and can't export file to png

scripts/resource.py Outdated Show resolved Hide resolved
docs/guides/node.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mingrammer
Copy link
Owner

+ Please resolve the conflicts

@McSly
Copy link
Contributor Author

McSly commented Feb 16, 2020

Changes requested have been made

@mingrammer
Copy link
Owner

mingrammer commented Feb 17, 2020

__init__.py is missing for OCI. Please add this file to diagrams/oci/__init__.py (it is not autogenerated.)

"""
OCI provides a set of services for Oracle Cloud provider.
"""

from diagrams import Node


class _OCI(Node):
    _provider = "oci"
    _icon_dir = "resources/oci"

    fontcolor = "#ffffff"

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll release a new version soon.

@mingrammer mingrammer merged commit a2b78fa into mingrammer:master Feb 18, 2020
@mingrammer
Copy link
Owner

Thank you for contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants