Add Saas (#89) #168
Add Saas (#89) #168
Conversation
|
I thunk the ElasticCloud and ElasticSearch would be better to move under the new WDYT? |
mingrammer
added
comp/node
|
Yes you are right it make more sense to move it to it's own provider. I'll make a new PR for 134. |
|
Got it and thanks for the review. |
|
Thank you :) |
Zuul is an open source program that drives continuous integration, delivery, and deployment systems with a focus on project gating and interrelated projects. https://zuul-ci.org/
* Add nodes for Firebase * Fix sort * Fix position of configuration to keep order consistency * Fix class names
|
My bad I rebased on master to resolve the conflict it resolve on local but still displayed here. I can create a new branch and make a different PR if there's problems. I removed elastic related files and push a new icon for slack. |
| @@ -104,6 +104,7 @@ def cleaner_programming(f): | |||
| "alibabacloud": cleaner_alibabacloud, | |||
| "oci": cleaner_oci, | |||
| "programming": cleaner_programming, | |||
| "saas": cleaner_onprem, | |||
There was a problem hiding this comment.
Please create a cleaner_saas. Redundant code is ok for this.
|
Slack logo is a little weird.
|
|
Thanks for the review,
|
|
Ye, feel free to make a new PR. |
|
#173 is now merged. |
Following the discussion on the issue I created the saas and add chat (chat instead of messenger as Messenger is the band name of the Facebook tool so we will end up with messenger.Messenger!) and social. I only add the example provided in the comment.
Originally I want to do the #134 but there was no saas provider... m(__)m