Update path to font file because existing path was giving an error #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrianLakstins |
gabriel-tessier
requested review from
gabriel-tessier,
mingrammer,
tvqphuoc01 and
filipeaaoliveira
gabriel-tessier
requested changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Dev Container for the first time was giving an error.
Tried accessing font file url https://noto-website.storage.googleapis.com/pkgs/NotoSansCJKjp-hinted.zip in browser and got error.
AccessDeniedAccess denied.Noticed that url in Docker/Dockerfile was different from url in docker/dev/Dockerfile.
Updated link in docker/dev/Dockerfile and tried opening in Dev Container and the process worked as expected.
Ran unit tests and autogen.sh in docker container and both ran without errors.