Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR, You can read all the details about here: about the https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md |
gabriel-tessier
requested review from
gabriel-tessier
and removed request for
gabriel-tessier
laiminhtrung1997
force-pushed
the
transit-gateway-attachment
branch
from
b191513 to
a621f92
Compare
|
Dear @gabriel-tessier, First, I appreciate you taking the time to review my contribution. I’ve implemented your recommendations: I updated the image and ran the autogen script. However, it generated a few additional changes. Should I remove these, or would it be better to add a new commit for them? Or should I leave them as is? Could you please review it again when you have a moment? Thank you very much! |
|
@laiminhtrung1997 |
laiminhtrung1997
force-pushed
the
transit-gateway-attachment
branch
from
a621f92 to
57f392b
Compare
|
I removed unrelated files. Please have a look again. Thank you. |
gabriel-tessier
requested review from
gabriel-tessier,
mingrammer,
tvqphuoc01 and
filipeaaoliveira
gabriel-tessier
approved these changes
Nov 17, 2024
filipeaaoliveira
approved these changes
Nov 18, 2024
gabriel-tessier
pushed a commit
that referenced
this pull request
Nov 20, 2024
gabriel-tessier
added a commit
that referenced
this pull request
Jan 13, 2025
* [979] Add icons * fix: icons size * bump: up to version 0.24.0 * Update version of codeql-analysis.yml (#1035) v2 will deprecate soon so we will move to v3 🌴 https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/ * Upgrade for 3.12/3.13 (#972) * fix tests (#1050) * chore(deps): bump jinja2 from 3.1.2 to 3.1.4 (#1037) * ci(test): add test trigger path * ci(test): add test trigger path * fix: update poetry lock * fix: keep the backward compatability for type hint (#1052) * Update installation command for mingrammer/round to use 'go install' with the latest version instead of 'go get'. (#1057) * fix(node): change elixir language image to one with no background (#976) * fix elixir image * fix website elixir image * Add diagrams.onprem.network.Mikrotik (#1058) * issue-982: add azure speech to text and Azure OpenAI (#1061) * Add Transit Gateway Attachment icon, its alias and Internet Gateway alias. (#1038) * issue-1056: add crowdstrike (#1062) * fix typo for crowdstrike (#1063) * Updated Legacy ENV Path (#1008) * Minor Change * fix: pin python version + fix font path * More recent Python version --------- Co-authored-by: tessier <[email protected]> * autogen.sh * Generate node * Revert build as node and set in _init * Clean generated files --------- Co-authored-by: mingrammer <[email protected]> Co-authored-by: Phuoc Tran <[email protected]> Co-authored-by: Tobias Bruckert <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nguyễn Đức Chiến <[email protected]> Co-authored-by: Gabriel Oliveira <[email protected]> Co-authored-by: laiminhtrung1997 <[email protected]> Co-authored-by: Abhishek Jadhav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.