Added support for PDO exception mode, which is default in PHP 8 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
boan-jfm
commented
Jul 5, 2022
| "ext-pdo": "*", | ||
| "mindplay/unbox": "^2", | ||
| "psr/log": "^1" | ||
| }, | ||
| "require-dev": { | ||
| "mindplay/testies": "^0.3.2", | ||
| "mindplay/benchpress": "^0.1", | ||
| "mockery/mockery": "^0.9", | ||
| "mockery/mockery": "^1.5.0", |
There was a problem hiding this comment.
This supports newer versions of PHP
| @@ -85,7 +85,7 @@ public function all() | |||
| * | |||
| * @return Iterator | |||
| */ | |||
| public function getIterator() | |||
| public function getIterator(): Iterator | |||
There was a problem hiding this comment.
Must adhere to the updated interface in new PHP versions
|
Thanks, but I'm not currently maintaining this. If you need these changes anytime soon, you should fork. |
|
Okay, thank you for the reply 👍 😊 |
mindplay-dk
reviewed
Nov 28, 2022
| @@ -104,7 +105,13 @@ public function execute() | |||
| { | |||
| $microtime_begin = microtime(true); | |||
|
|
|||
| if (@$this->handle->execute()) { | |||
| try { | |||
| $execution_successful = @$this->handle->execute(); | |||
There was a problem hiding this comment.
We probably shouldn't @ error-suppress in a try/catch?
|
I've done some maintenance today, the project should be in a better state for PHP 8 now. I've reviewed the change - if you'd like to update this PR, I will merge it. |
|
Fixed in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for PDO error mode set to
ERRMODE_EXCEPTION, which is the new default in PHP 8.Added return type to the
getIteratormethod within theResultmodel extending theIteratorAggregate. This has added return types in new PHP versions.Resolves #51