Skip to content

feat(workflow): add native DSH synchronization - #13

Merged
taosu0216 merged 2 commits into
mindfold-ai:mainfrom
SajoLuo:agent/dsh-native-workflow-followup
Aug 14, 2026
Merged

taosu0216 merged 2 commits into
mindfold-ai:mainfrom
SajoLuo:agent/dsh-native-workflow-followup

Conversation

@SajoLuo

@SajoLuo SajoLuo commented Aug 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • move DeepSeek Harness from the inline route to Trellis's native sub-agent route on the beta workflow
  • document collision-free trellis-agent-* role skills and exact-once child loading
  • use the optional trellis_wait tool for event-driven settlement when available
  • fall back to initial run_in_background: false dispatch when the plugin is absent; never poll or sleep
  • preserve the cross-platform operational guardrail: on Claude Code, dispatch these roles through the Task/Agent tool, never the Skill tool

Reproducibility

workflows/native/workflow.md at 08a258f0 is byte-identical to both the bundled beta workflow and the dogfood workflow at Trellis PR #548 head e3ba39f1. The Trellis template test enforces this mirror, and the clean Linux CLI suite passes 1807 tests across 77 files.

Dependency

This is the marketplace companion for mindfold-ai/Trellis#548 against feat/v0.7-beta. The adapter does not install the optional dsh-trellis profile plugin.

Summary by CodeRabbit

  • Documentation
    • Added guidance for using DeepSeek Harness in native workflows, including platform routing, research, context setup, implementation, and completion criteria.
    • Clarified DeepSeek agent-skill loading, foreground execution, event-driven waiting, and settlement handling.
    • Separated Codex-inline and DeepSeek Harness workflow instructions.
    • Strengthened quality-check requirements so skipped or unsuccessful checks are treated as failures.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9afeffe2-6894-49e0-a3bf-90d7050644fe

📥 Commits

Reviewing files that changed from the base of the PR and between d286b2c and 08a258f.

📒 Files selected for processing (1)
  • workflows/native/workflow.md

📝 Walkthrough

Walkthrough

The native workflow adds DeepSeek Harness to platform routing, research, context loading, implementation, and quality-check procedures. It separates DeepSeek Harness behavior from inline-platform behavior and defines waiting and failure rules.

Changes

DeepSeek Harness workflow support

Layer / File(s) Summary
Platform routing and context rules
workflows/native/workflow.md
DeepSeek Harness now uses sub-agent routing and curated implement.jsonl and check.jsonl context manifests.
Research and sub-agent dispatch
workflows/native/workflow.md
Research and sub-agent dispatch load role skills and use trellis_wait or foreground execution without polling.
Implementation and quality-check execution
workflows/native/workflow.md
Implementation and quality-check flows define skill loading, wait behavior, synchronous fallback, and failure handling for skipped or unsuccessful required checks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: cnhlaia

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@taosu0216

Copy link
Copy Markdown
Contributor

Verified as part of the combined review on mindfold-ai/Trellis#548 — full notes there.

Byte-identical to the bundled template in that PR (diffed directly, 714 lines), so the mirror test stays green. All five block markers moved from the inline group to the sub-agent group in matched open/close pairs, with nothing left behind.

One wording point on the generalized Tools: line, detailed in the #548 comment: the rewrite drops the tool name and the explicit "not the Skill tool" negation for every platform in order to fix a claim that was only wrong on DSH. Suggested replacement wording is in that comment.

Merging this first is the right order — Trellis#548 records this exact commit as its submodule pointer and should be repointed at the merged SHA before it comes out of draft.

@taosu0216
taosu0216 marked this pull request as ready for review August 14, 2026 05:55
@taosu0216
taosu0216 merged commit cfb2f38 into mindfold-ai:main Aug 14, 2026
1 check passed
taosu0216 pushed a commit to mindfold-ai/Trellis that referenced this pull request Aug 14, 2026
Routes DeepSeek Harness through native sub-agent dispatch instead of the inline workflow, as the follow-up to #547 agreed in that thread.

- collision-free child-only `trellis-agent-{research,implement,check}` role skills with the pull-based context prelude; the main session never loads them itself
- capability-aware synchronization: the optional `dsh-trellis` companion's event-driven `trellis_wait` when present, initial foreground dispatch when absent, never polling or sleeping
- `trellis init --dsh` still installs no profile plugin — project-level init does not write to the user's dsh profile
- nested-host session identity: managed `DSH_TRELLIS_CONTEXT_ID` first, then `DSH_SHELL=1` plus `DSH_SESSION_ID` resolving through the canonical env table ahead of an inherited `TRELLIS_CONTEXT_ID`, with the generic override keeping its precedence everywhere else
- bundled, dogfood and marketplace workflow mirrors byte-identical

Companion changes merged first: mindfold-ai/marketplace#13 (cfb2f38), mindfold-ai/docs#31 (59d5b37). Beta docs only; stable stays as shipped in 0.6.15, where dsh runs inline.

Verified against a real dsh 0.1.0-rc.6: the `subagent` tool schema matches the dispatch instructions, the plugin-absent foreground path settles end to end, and a managed dsh shell resolves its own session identity rather than an inherited outer one.

Co-authored-by: SajoLuo <SajoLuo@users.noreply.github.com>
sdelmas added a commit to sdelmas/marketplace that referenced this pull request Aug 25, 2026
Rescued local branch: mirrors the 2026-08-09 Trellis changes (required
--description on task create, task.py rename, empty jsonl manifests) into
the skills and workflow copies. Auto-merged clean; the DSH additions from
mindfold-ai#13/mindfold-ai#14 are untouched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants