fix(cli): detect platform installs from Trellis-owned files - #501
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughChangesPlatform detection
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant getConfiguredPlatforms
participant TemplateManifest
CLI->>getConfiguredPlatforms: request configured platforms
getConfiguredPlatforms->>TemplateManifest: load tracked template hashes
TemplateManifest-->>getConfiguredPlatforms: return owned template paths
getConfiguredPlatforms-->>CLI: return matching platform IDs
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
thank you |
BaSui01
pushed a commit
to BaSui01/Trellis
that referenced
this pull request
Aug 5, 2026
Co-authored-by: taosu <taosu@mindfold.ai> (cherry picked from commit c41c8bd)
Xio-Shark
pushed a commit
to Xio-Shark/Trellis
that referenced
this pull request
Sep 17, 2026
Co-authored-by: taosu <taosu@mindfold.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agents/skillsfiles cannot create false positivesRoot cause
getConfiguredPlatforms()treated any native platform directory as proof that Trellis had configured that platform. Existing.claude,.codex, or other tool directories therefore caused re-init to skip the requested platform even when its Trellis files had never been generated.Validation
pnpm testpnpm lintpnpm typecheckpnpm buildFixes #500
Summary by CodeRabbit
Bug Fixes
Documentation
Tests