fix(hooks): adapt SessionStart acknowledgment language - #439
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughSessionStart first-reply notices no longer require Chinese. Specifications and platform templates now define adaptive language selection with a neutral fallback, while tests validate payload structure, notice content, ordering, and reinjection behavior. ChangesAdaptive SessionStart acknowledgment
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
taosu0216
left a comment
There was a problem hiding this comment.
Reviewed in depth: notice wording verified byte-equivalent across shared/Codex/OpenCode/Pi templates, Copilot stays notice-free, full CLI suite 1389/1389 green, no payload-shape regressions. Thanks for the careful fix!
…dfold-ai#448 merge batch Fill gaps left after mindfold-ai#439 (SessionStart language-adaptive notice) and mindfold-ai#445 (Codex native SubagentStart dispatch) already updated platform-integration.md, and cover mindfold-ai#448's five behavior changes: preferOffline removal, `trellis platforms --json`, task.py list/current --json + display_status roll-up, base_branch/stale-branch git helpers, channel spawn --sandbox, and the Pi skills .pi/skills/ -> .agents/skills/ move.
Co-authored-by: Claude <noreply@anthropic.com>
…dfold-ai#448 merge batch Fill gaps left after mindfold-ai#439 (SessionStart language-adaptive notice) and mindfold-ai#445 (Codex native SubagentStart dispatch) already updated platform-integration.md, and cover mindfold-ai#448's five behavior changes: preferOffline removal, `trellis platforms --json`, task.py list/current --json + display_status roll-up, base_branch/stale-branch git helpers, channel spawn --sandbox, and the Pi skills .pi/skills/ -> .agents/skills/ move.
docs(spec): refresh contracts for mindfold-ai#439/mindfold-ai#445/mindfold-ai#448 merge batch
Summary
Trellis SessionStart ✓Why
The existing notice requires a fixed Chinese sentence. Because the notice is model-visible after startup,
/clear, and compaction, it can steer an otherwise non-Chinese conversation into Chinese.The acknowledgment was intentionally added as cross-platform proof that otherwise-hidden SessionStart context loaded, so this change keeps that observability instead of removing it. Language selection happens when the first visible reply is generated, when the triggering user message is normally available. No OS-locale or repository-content guessing is introduced.
Validation
git diff --checkpassedFixes #412
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation
Tests