[To keep] -- [build] tf upgrade by keeping keras v2

[felixdittrich92]

This PR:

• upgrade TF by staying at keras v2

@odulcy-mindee This would work if we want to upgrade tf by keeping keras at version 2 without the need to change the current model saving/loading / refactoring everything (would be only a temp fix)

I'm super unhappy with this PR but i don't see an alternative atm 😓

[odulcy-mindee]

Why did you set TF_USE_LEGACY_KERAS=1 everywhere as it is the default behavior of your PR ?

[felixdittrich92]

Why did you set TF_USE_LEGACY_KERAS=1 everywhere as it is the default behavior of your PR ?

The behavior of this env variable is super strange:

By installing TF>= 2.16 it installs automatically keras>=3.0.0 so tf.keras is additonal installed (to keep keras v2 backwards compatibility with tf >= 2.16)

I'm not sure why it works for everything ..without the latency scripts there it jumps all the time to keras 3 (also on the CI job) without setting TF_USE_LEGACY_KERAS=1 in front of your script - which leads to errors

[felixdittrich92]

@odulcy-mindee Now it works

• Added as function instead of os.environ .. in every script which makes it easier to remove later on if we have a solution with keras v3

[codecov]

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.46%. Comparing base (dccc26b) to head (9940348).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
doctr/file_utils.py	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
+ Coverage   96.39%   96.46%   +0.07%     
==========================================
  Files         164      164              
  Lines        7823     7869      +46     
==========================================
+ Hits         7541     7591      +50     
+ Misses        282      278       -4     

Flag	Coverage Δ
unittests	96.46% <94.28%> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[odulcy-mindee]

Why no more tf.function ?

[felixT2K]

Before it was disabled globally so no tf.function has had any effect
the functions where the tf.function annotation is removed makes use of numpy which is not compatible with the compilation (which is triggered for the tf.function annotated functions)

[felixdittrich92]

On hold

[felixdittrich92]

@odulcy-mindee Our fallback if we don't have a working version with keras v3 end of the year :)