feat: start an autodiff poc. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed the tests here ! Good work guys, although we need to merge #96 first |
chaithyagr
reviewed
Apr 26, 2024
tests/test_autodiff.py
Outdated
| samples=kspace_loc, | ||
| shape=shape, | ||
| smaps=None, | ||
| squeeze_dims=False, # Squeezing breaks dimensions ! |
There was a problem hiding this comment.
@paquiteau I think we need a check for this. We need squeeze_dims to be false for now if we want autograd to work good.
chaithyagr
reviewed
Apr 29, 2024
src/mrinufft/operators/autodiff.py
Outdated
| def __init__(self, nufft_op): | ||
| super().__init__() | ||
| if nufft_op.squeeze_dims: | ||
| raise ValueError("Squeezing dimensions is not " |
There was a problem hiding this comment.
Here, we check if squeeze_dims is True, we raise an error
added 3 commits
April 29, 2024 11:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.