Dispatch density methods in operators #68
Conversation
| @@ -35,7 +35,7 @@ | |||
| display_3D_trajectory, | |||
| ) | |||
|
|
|||
| from .density import voronoi, cell_count, pipe | |||
| from .density import voronoi, cell_count, pipe, get_density | |||
There was a problem hiding this comment.
In documentation I recommend mentioning a bit about each including computation times
| return new_traj | ||
|
|
||
|
|
||
| class MethodRegister: |
There was a problem hiding this comment.
Was this abstraction really needed and helpful? Especially when we have only 3 density methods and also in which only 2 are used. Although, i understand you are trying to be future proof.
There was a problem hiding this comment.
Although, i understand you are trying to be future proof.
Yep, Maybe we would like to collect other type of methods as well at one point (e.g. trajectories)
| if not callable(method): | ||
| raise ValueError(f"Unknown density method: {method}") | ||
|
|
||
| self.density = method(self.samples, self.shape, **kwargs) |
There was a problem hiding this comment.
Under the current framework, how can we change shape? In case I want to compute density for a larger OSF i.e. COnventionally Pipe is done for OSF=2 (as all NUFFT is done for OSF=2)
There was a problem hiding this comment.
Also i am curious how can we pass additional arguments through these wrappers? I see **kwargs, but how can we use them while say instancing a NUFFT operator? Is this doable?
paquiteau
force-pushed
the
density_register
branch
from
e257a13 to
98f7a8a
Compare
paquiteau
force-pushed
the
density_register
branch
from
1c04fb3 to
ddf26d2
Compare
paquiteau
force-pushed
the
density_register
branch
4 times, most recently
from
6ebc269 to
677055a
Compare
paquiteau
force-pushed
the
density_register
branch
from
677055a to
63e5d1a
Compare
paquiteau
force-pushed
the
density_register
branch
from
adf8b8c to
ffe7a70
Compare
|
The call for grid_op.op(grid_op.adj_op(density_comp, True), True) |
This PR allow to dispatch the choice for density compensation estimation. It also provides a
get_densitymethods and can show which density compensation methods are available.Also, It provides a generic purpose
MethodRegisterthat could be used for registering other collection of methods (trajectories functions for example).