Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple unet training #199

Merged
merged 39 commits into from
Nov 13, 2024
Merged

Simple unet training #199

merged 39 commits into from
Nov 13, 2024

Conversation

Lenoush
Copy link
Contributor

@Lenoush Lenoush commented Sep 23, 2024

No description provided.

@Lenoush Lenoush requested a review from chaithyagr September 23, 2024 13:49
@Lenoush Lenoush self-assigned this Sep 23, 2024
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fairly quick.
Please make a commit with "!docs_build", to ensure we build docs for verification

@Lenoush Lenoush marked this pull request as draft September 23, 2024 14:21
@Lenoush Lenoush marked this pull request as ready for review September 23, 2024 14:24
@Lenoush Lenoush requested a review from chaithyagr September 24, 2024 10:32
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I still need to review the built docs.

@Lenoush Lenoush requested a review from chaithyagr September 25, 2024 12:26
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
A bunch of important comments to handle for a clean documentations.

@Lenoush Lenoush requested a review from chaithyagr October 8, 2024 07:35
@chaithyagr chaithyagr requested a review from paquiteau November 8, 2024 14:40
@chaithyagr chaithyagr assigned chaithyagr and unassigned Lenoush Nov 8, 2024
Comment on lines 9 to 10
This is implemented in the proprietary FASTMRI package [fastmri]_.
Users are encouraged to contact the authors if they want to use it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's not necessary here (we are not talking about sparkling)


# Generate images for gif
hashed = joblib.hash((i, "learn_traj", time.time()))
filename = "/tmp/" + f"{hashed}.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tmpdir (like the other examples)

@chaithyagr chaithyagr requested a review from paquiteau November 13, 2024 08:11
Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaithyagr chaithyagr merged commit 14c2738 into master Nov 13, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants