-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple unet training #199
Simple unet training #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fairly quick.
Please make a commit with "!docs_build", to ensure we build docs for verification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I still need to review the built docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
A bunch of important comments to handle for a clean documentations.
examples/GPU/example_fastMRI_UNet.py
Outdated
This is implemented in the proprietary FASTMRI package [fastmri]_. | ||
Users are encouraged to contact the authors if they want to use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's not necessary here (we are not talking about sparkling)
examples/GPU/example_fastMRI_UNet.py
Outdated
|
||
# Generate images for gif | ||
hashed = joblib.hash((i, "learn_traj", time.time())) | ||
filename = "/tmp/" + f"{hashed}.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use tmpdir (like the other examples)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.