Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TURBINE & REPI examples, fixes and improvements #186

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Conversation

Daval-G
Copy link
Collaborator

@Daval-G Daval-G commented Aug 31, 2024

This PR consists of the following:

@Daval-G Daval-G added bug Something isn't working trajectories Issues concerning Non cartesian trajectories labels Aug 31, 2024
@Daval-G Daval-G requested a review from paquiteau August 31, 2024 08:02
@Daval-G Daval-G self-assigned this Aug 31, 2024
Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far :)

could you trigger a build_docs commit to check that the example is correctly generated ?

@Daval-G
Copy link
Collaborator Author

Daval-G commented Sep 2, 2024

could you trigger a build_docs commit to check that the example is correctly generated ?

How to do that ?

@paquiteau
Copy link
Member

Just push a commit with !docs_build in the commit message :)

if: ${{ contains(needs.get-commit-message.outputs.message, '!docs_build') || github.ref == 'refs/heads/master' }}

@Daval-G Daval-G merged commit 616b63a into master Sep 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working trajectories Issues concerning Non cartesian trajectories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants