-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
150 right shape #161
150 right shape #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we dont need to send the shape in. Also, we might need to be careful and check only last 2 or 3 dimensions (in case we have batches)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All CPU based backend should rather be handled via the FourierOperatorCPU.op
.
Otherwise this LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I think the codes are a bit confusing and some things can be refactored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, getting nitpicky now, but a couple of important changes also.
Co-authored-by: Chaithya G R <[email protected]>
Co-authored-by: Chaithya G R <[email protected]>
Co-authored-by: Chaithya G R <[email protected]>
Co-authored-by: Chaithya G R <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions, otherwise this seems good.
Co-authored-by: Pierre-Antoine Comby <[email protected]>
Co-authored-by: Pierre-Antoine Comby <[email protected]>
Co-authored-by: Pierre-Antoine Comby <[email protected]>
Co-authored-by: Pierre-Antoine Comby <[email protected]>
cb4296e
to
534bc2d
Compare
answer to #150
Basically, every time you call op and adj_op, make sure the input image is of the shape , which was provided during initialization.
The CPU-based backend is handled differently