Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

150 right shape #161

Merged
merged 61 commits into from
Aug 30, 2024
Merged

150 right shape #161

merged 61 commits into from
Aug 30, 2024

Conversation

Lenoush
Copy link
Contributor

@Lenoush Lenoush commented Jul 12, 2024

answer to #150

Basically, every time you call op and adj_op, make sure the input image is of the shape , which was provided during initialization.

  • create a function that checks whether the shape of the image (in this case, the data) == self.shape (from init)
  • call it when op
  • test this function
  • call it when adj_op

The CPU-based backend is handled differently

@Lenoush Lenoush requested a review from chaithyagr July 12, 2024 11:06
@Lenoush Lenoush linked an issue Jul 12, 2024 that may be closed by this pull request
@Lenoush Lenoush marked this pull request as draft July 12, 2024 11:06
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we dont need to send the shape in. Also, we might need to be careful and check only last 2 or 3 dimensions (in case we have batches)

@chaithyagr chaithyagr marked this pull request as ready for review July 15, 2024 06:54
@Lenoush Lenoush marked this pull request as draft July 25, 2024 11:58
Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CPU based backend should rather be handled via the FourierOperatorCPU.op.

Otherwise this LGTM

@chaithyagr chaithyagr marked this pull request as ready for review July 26, 2024 09:58
@Lenoush Lenoush marked this pull request as draft July 26, 2024 12:08
@Lenoush Lenoush requested a review from paquiteau August 28, 2024 12:56
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think the codes are a bit confusing and some things can be refactored

@Lenoush Lenoush requested a review from chaithyagr August 29, 2024 08:25
Copy link
Member

@chaithyagr chaithyagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, getting nitpicky now, but a couple of important changes also.

Copy link
Member

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions, otherwise this seems good.

Lena OUDJMAN and others added 4 commits August 30, 2024 11:04
@Lenoush Lenoush marked this pull request as draft August 30, 2024 09:09
@paquiteau paquiteau marked this pull request as ready for review August 30, 2024 11:57
@paquiteau paquiteau merged commit e4dc519 into master Aug 30, 2024
12 checks passed
@paquiteau paquiteau deleted the 150-right-shape branch August 30, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that input image data is of right shape and order
3 participants