Skip to content

Commit

Permalink
refactor: prefers using mix.exs for application env defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
grzuy committed Sep 2, 2024
1 parent 01ce705 commit 9ed3c45
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 1 addition & 3 deletions lib/tower.ex
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,6 @@ defmodule Tower do

alias Tower.Event

@default_reporters [Tower.EphemeralReporter]

@doc """
Determines if a process exit `reason` is "normal".
Expand Down Expand Up @@ -450,7 +448,7 @@ defmodule Tower do
end

defp reporters do
Application.get_env(:tower, :reporters, @default_reporters)
Application.fetch_env!(:tower, :reporters)
end

defp async(fun) do
Expand Down
3 changes: 1 addition & 2 deletions lib/tower/logger_handler.ex
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
defmodule Tower.LoggerHandler do
@moduledoc false

@default_log_level :critical
@handler_id Tower
@own_logs_domain [:tower, :logger_handler]

Expand Down Expand Up @@ -101,7 +100,7 @@ defmodule Tower.LoggerHandler do
defp log_level do
# This config env can be to any of the 8 levels in https://www.erlang.org/doc/apps/kernel/logger#t:level/0,
# or special values :all and :none.
Application.get_env(:tower, :log_level, @default_log_level)
Application.fetch_env!(:tower, :log_level)
end

defp safe_log(level, message) do
Expand Down
4 changes: 4 additions & 0 deletions mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ defmodule Tower.MixProject do
def application do
[
extra_applications: [:logger, :inets],
env: [
reporters: [Tower.EphemeralReporter],
log_level: :critical
],
mod: {Tower.Application, []}
]
end
Expand Down

0 comments on commit 9ed3c45

Please sign in to comment.