remove unnecessary object duplication #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`load_from_json` returns a list of newly created MIME::Type objects, so there is no need to loop through all of them again, convert them to hashes, then allocate duplicate MIME::Type objects. <3<3
|
Well, that’s somewhat embarrassing. Thanks! |
|
@halostatue the secret is safe with me!! Thanks for merging! ❤️❤️❤️❤️❤️❤️❤️❤️❤️ |
halostatue
added a commit
that referenced
this pull request
Oct 15, 2014
remove unnecessary object duplication
|
It may not matter much in normal runs, but the JSON data now loads about 45% faster. |
|
🚀 🚀 🚀 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_from_jsonreturns a list of newly created MIME::Type objects, sothere is no need to loop through all of them again, convert them to
hashes, then allocate duplicate MIME::Type objects.
<3<3