Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_blocks API call - set tail height to include genesis #3773

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

yeastplume
Copy link
Member

When calling the get_blocks function with a start height of 0, the start height is adjusted to the 'tail', or the earliest stored block. The tail function appears to be returning 1 in the case of an archive node, causing the call to skip block 0. This adjusts the start height in that single case to make the API more consistent.

@pkariz
Copy link

pkariz commented Oct 3, 2023

get_blocks is returning as expected now, thanks!

@yeastplume yeastplume merged commit 5dcbe96 into mimblewimble:master Oct 4, 2023
bayk added a commit to mwcproject/mwc-node that referenced this pull request Jun 23, 2024

Verified

This commit was signed with the committer’s verified signature.
bayk Konstantin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants