Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ROARING_ARCH environment variable #3644

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Fix ROARING_ARCH environment variable #3644

merged 1 commit into from
Jun 10, 2021

Conversation

quentinlesceller
Copy link
Member

Good catch @antiochp :). Fixes #3641.

@quentinlesceller quentinlesceller mentioned this pull request Jun 1, 2021
Closed
@GeneFerneau
Copy link
Contributor

Does there also need to be an environment variable to disable croaring on some arches as suggested here and here?

@quentinlesceller
Copy link
Member Author

My understanding is that with the x86-64-v2 arch, croaring will not use AVX and as such is compatible with all archs. Or did I miss something?

@GeneFerneau
Copy link
Contributor

I just wasn't sure, saw mention of the disable env var, didn't know if it was necessary for some builds.

@phyro
Copy link
Member

phyro commented Jun 7, 2021

Should we go ahead and merge this one and prepare a new minor release? Then perhaps people at #3641 can give it a try

@quentinlesceller quentinlesceller merged commit 172143f into mimblewimble:master Jun 10, 2021
@quentinlesceller quentinlesceller deleted the env branch June 10, 2021 13:42
@quentinlesceller
Copy link
Member Author

Merged! Unsure if we need a minor release for that though.

@quentinlesceller quentinlesceller mentioned this pull request Aug 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneFerneau GeneFerneau GeneFerneau approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grin node 5.1.0 won't launch on Linux
3 participants
@quentinlesceller @GeneFerneau @phyro