better naming of APIs file and variables #3525

deevope · 2020-12-14T23:21:13Z

Changed name of .foreign_api_secret to .node_foreign_api_secret and .api_secret to .node_owner_api_secret
Better naming of node owner_api variables

jaspervdm · 2020-12-15T14:38:24Z

I like the new names however we should consider how it breaks current setups and think if/how we can have some type of backwards compatibility.

antiochp · 2020-12-16T12:38:56Z

I believe we are using a limited fix from mimblewimble/grin-wallet#546 for 5.0.x.
We can revisit the naming post HF.

deevope · 2021-04-04T06:29:44Z

@quentinlesceller feel free to review when you have some time but need to review in first place PR#544 first before merging.

This reverts commit f80e5c6.

quentinlesceller self-requested a review December 15, 2020 15:35

deevope changed the title ~~better naming of APIs file and variables~~ [WIP] better naming of APIs file and variables Dec 19, 2020

phyro mentioned this pull request Mar 15, 2021

better naming of APIs files and variables mimblewimble/grin-wallet#544

Closed

deevope force-pushed the api_file_node branch from 5b902a0 to 3543cde Compare March 26, 2021 01:51

deevope added 3 commits March 30, 2021 07:07

better naming of APIs file and variables

e080dca

typo...

b064cdf

forward compatibility config

260a47e

deevope force-pushed the api_file_node branch from e1d4d30 to 260a47e Compare March 30, 2021 07:08

deevope changed the title ~~[WIP] better naming of APIs file and variables~~ better naming of APIs file and variables Apr 2, 2021

deevope changed the title ~~better naming of APIs file and variables~~ [WIP] better naming of APIs file and variables Apr 2, 2021

deevope added 2 commits April 4, 2021 06:24

api file exist + api file path if config exists

09d627b

update api docs

e39a357

deevope changed the title ~~[WIP] better naming of APIs file and variables~~ better naming of APIs file and variables Apr 4, 2021

deevope added 3 commits April 4, 2021 19:06

soft compatibility

f80e5c6

Revert "soft compatibility"

527251e

This reverts commit f80e5c6.

hard compatibility

41589a0

deevope closed this Jun 11, 2021

Provide feedback