PIBD segment p2p messages #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#3482 is now merged. |
|
👀 |
antiochp
reviewed
Nov 25, 2020
Comment on lines
+374
to
+378
| Message::OutputBitmapSegment(_) | ||
| | Message::OutputSegment(_) | ||
| | Message::RangeProofSegment(_) | ||
| | Message::KernelSegment(_) => Consumed::None, | ||
|
|
There was a problem hiding this comment.
This is just a /dev/null placeholder for now?
There was a problem hiding this comment.
Yes, nodes receiving segments just ignore them.
antiochp
reviewed
Nov 25, 2020
servers/src/common/adapters.rs
Outdated
| hash: Hash, | ||
| id: SegmentIdentifier, | ||
| ) -> Result<Segment<TxKernel>, chain::Error> { | ||
| if id.height < 9 || id.height > 13 { |
There was a problem hiding this comment.
We should pull these min and max heights out into const so its easier to see them all together.
antiochp
approved these changes
Nov 25, 2020
antiochp
reviewed
Nov 25, 2020
| @@ -46,6 +46,12 @@ use crate::util::OneTime; | |||
| use chrono::prelude::*; | |||
| use chrono::Duration; | |||
| use rand::prelude::*; | |||
| use std::ops::Range; | |||
|
|
|||
| const KERNEL_SEGMENT_HEIGHT_RANGE: Range<u8> = 9..14; | |||
There was a problem hiding this comment.
Nice. Didn't think of using ranges here. 👍
5 tasks
Closed
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 11, 2024
* Define PIBD segment p2p messages * Respond to segment requests * Use specialized (de)ser for output bitmap segments * Allowed segment height ranges in const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new p2p messages as defined in this RFC. Only merge after #3482 and #3492.
Until then we use a placeholder
Segmenterthat just panics on usage.Enforce segment height limitsRebase once 3482 is mergedSwitch toBitmapSegmentin place ofSegment<BitmapChunk>inOutputBitmapSegmentresponses