reorg cache fix #3495
Merged
reorg cache fix #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
reviewed
Nov 24, 2020
pool/src/types.rs
Outdated
| // Reorg cache retention period in minute. | ||
| // The reorg cache repopulates local mempool in a reorg scenario. | ||
| #[serde(default = "default_reorg_cache_period")] | ||
| pub reorg_cache_period: i64, |
There was a problem hiding this comment.
Lets make this u64 as it does not make sense to support -ve values in the config.
There was a problem hiding this comment.
I can't do u64, as minutes() requires i64. Either we set it to u32 and turn it into i64 in minutes() or we just let i64 but no error will be thrown if users put a negative value.
There was a problem hiding this comment.
u32 works then, we're not going to need huge values in here.
antiochp
reviewed
Nov 24, 2020
antiochp
approved these changes
Nov 25, 2020
|
Going to merge this for 5.0.0 beta. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3489
reorg cache period configurable : Allow everyone to configure themselves the reorg cache period, so they could increase it easily in function of their constraint. To repopulate their local mempool.
treat cached txs as "new" during reconciliation : Allow our nodes to broadcast txs to their peers.increase max pool size to 300K txs : To prevent for the future, in case of large reorg with empty blocks, against stale full blocks, nodes mempool should be able to handle 6 hours of transactions of full blocks.Evict duplicate txs in reorg cache : Given we add transactions back transaction to the pool, and in the pool we add them back in the reorg cache, we remove them from the reorg cache before they are sent in the pool.Evict only txs accepted to pool and sourced from reorg cache when rec… : Fix of commit 3d8df3a, It will evict only from reorg cache, transactions sourced from reorg cache, accepted by the pool to be broadcasted and added to the reorg_cache again. As we want to keep every transactions that were not accepted by the pool in the reorg_cache in the case where a reorg with larger depth happen again.test:
reorg on testnet made, node rebroadcasted successfully the transactions to other peersI plan also to make a stress test on testnet with 50k transactions - not done yet.