Disable merkle proofs for v2 get_block #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinlesceller
requested changes
Nov 9, 2020
api/src/foreign_rpc.rs
Outdated
Comment on lines
138
to
142
| curl -X POST \ | ||
| -H 'Content-Type: application/json' \ | ||
| -d '{"jsonrpc":"2.0","id":1,"method":"get_block","params":[952019, null, null]}' \ | ||
| http://localhost:3413/v2/foreign | ||
|
|
There was a problem hiding this comment.
What's that? The doctests (currently disabled) are just below.
api/src/foreign_rpc.rs
Outdated
| { | ||
| "jsonrpc": "2.0", | ||
| "method": "get_block", | ||
| "params": [374274, null, null], |
There was a problem hiding this comment.
This is the value you want to change here I guess
|
Other than that everything looks good to me. |
antiochp
force-pushed
the
disable_merkle_proofs
branch
from
356ee4a to
593d4e6
Compare
quentinlesceller
approved these changes
Nov 9, 2020
Closed
26 tasks
bayk
added a commit
to mwcproject/mwc-node
that referenced
this pull request
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR defaults to
include_merkle_proof = falsein the v2 apiget_blockjsonrpc endpoint.These Merkle proofs are not actively used by anyone and were originally included (I believe) as a "proof of concept".
They are expensive to generate for historical blocks (specifically against a full archival node).
Related #3483.
Tested via -
This is equivalent behavior to the optional
?no_merkle_proofurl param in the original v1 api endpoint -