HardFork4 #3478
HardFork4 #3478
Conversation
| new_cuckarood_ctx(edge_bits, proof_size) | ||
| if chain_type == ChainTypes::Mainnet || chain_type == ChainTypes::Testnet { | ||
| // Mainnet and Testnet have Cuckatoo31+ for AF and Cuckaroo{,d,m,z}29 for AR | ||
| if edge_bits > 29 { |
There was a problem hiding this comment.
Consider making this explicit on header_version() also?
if header_version(height) >= 5 || edge_bits > 29 {
...
}
Would we then want to explicitly fail if we actually had edge_bits <= 29 after HF4?
I guess this depends on how we are thinking about this. This is driven off edge_bits in this PR and we fallthrough to no_cuckaroo_ctx() if edge_bits are too low and we are beyond HF4.
My only concern here is that is not immediately intuitive.
There was a problem hiding this comment.
Asking for a 29 context past HF4 should result in a clear error such as no_cuckaroo_ctx() rather than a dubious CuckAToo29 context, which is not an outright error, but otherwise quite invalid.
There was a problem hiding this comment.
Yes absolutely - just wondering if there is a more explicit way of implementing this, failing earlier in the code with a no_cuckatoo_ctx().
|
fixes: #3472 |
name: HardFork4
about: make header version 5 valid forever at 2*YEAR_HEIGHT
title: Hard Fork 4
labels: consensus-breaking, must-have, critical
assignees: antiochp, quentinlesceller, yeastplume
Still needs proper setting of TESTNET_FOURTH_HARD_FORK;
waiting for testnet to progress at predictable pace...