Get the hash of a PMMR leaf ignoring the leafset #3463
Closed
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
reviewed
Oct 6, 2020
| @@ -39,6 +39,9 @@ pub trait Backend<T: PMMRable> { | |||
| /// Get a Hash by insertion position. | |||
| fn get_hash(&self, position: u64) -> Option<Hash>; | |||
|
|
|||
| /// Get a leaf hash by insertion position, ignoring the leaf set | |||
There was a problem hiding this comment.
This should not be necessary - we already have get_from_file() below, which does exactly this.
| @@ -34,6 +34,9 @@ pub trait ReadablePMMR { | |||
| /// Get the hash at provided position in the MMR. | |||
| fn get_hash(&self, pos: u64) -> Option<Hash>; | |||
|
|
|||
| /// Get the hash of a leaf, ignoring the leaf set | |||
| fn get_leaf_hash(&self, pos: u64) -> Option<Hash>; | |||
There was a problem hiding this comment.
Same - we already have get_from_file() below.
|
Yep, my mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a leaf is marked for removal (using the leafset), its hash is not actually removed from the backend until its sibling is also removed. The
get_hashfunction on the PMMR will return aNonefor hashes that are marked for removal but not actually pruned yet. However in this PR we need access to this hash. So here we introduce a new function on the PMMR and Backend that will return a leaf hash, ignoring the leafset.