use AsRef in cut_through for flexibility #3411
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
cut_through()
more idiomatic, making it significantly more flexible in terms of what we can do with it.It now takes two slices of anything that is
AsRef<Commitment>
.So we can cut_through
inputs
andoutputs
.We can also cut_through
inputs
andoutput identifiers
.We could also (if we wanted) cut_through
inputs
andinputs
, finding the intersection and difference in the process.Also took the opportunity to refactor finding the total len() of all inputs, outputs, kernels in
aggregate()
usingfold()
to remove somemut
definitions.