Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this test was jamming up in azure CI #3349

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

antiochp
Copy link
Member

No description provided.

Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@antiochp
Copy link
Member Author

antiochp commented Jun 10, 2020

This is happening on azure now -

thread 'peer_read' panicked at 'GLOBAL_CHAIN_TYPE and CHAIN_TYPE unset. Consider set_local_chain_type() in tests.', core/src/global.rs:172:17
stack backtrace:
error: test failed, to rerun pass '-p grin_p2p --test peer_handshake'

Still investigating.

This is weird as we see an error locally, but test passes...

thread 'peer_read' panicked at 'GLOBAL_CHAIN_TYPE and CHAIN_TYPE unset. Consider set_local_chain_type() in tests.', core/src/global.rs:172:17
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test peer_handshake ... ok

@quentinlesceller
Copy link
Member

Also why macOS only

@antiochp
Copy link
Member Author

This has to be a timing/test ordering issue.
Lets see if it passes with these changes.

@antiochp antiochp merged commit 6757a30 into mimblewimble:master Jun 10, 2020
@antiochp antiochp deleted the fix_ci_test_jam branch June 10, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants