Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unwraps in LMDB client #3313

Merged
merged 1 commit into from
May 13, 2020
Merged

Remove some unwraps in LMDB client #3313

merged 1 commit into from
May 13, 2020

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Apr 29, 2020

No description provided.

@hashmap hashmap requested a review from antiochp April 29, 2020 19:01
antiochp
antiochp reviewed May 1, 2020
View reviewed changes
store/src/lmdb.rs
Comment on lines -261 to +264
db: RwLockReadGuard<'_, Option<Arc<lmdb::Database<'static>>>>,
db: Arc<lmdb::Database<'static>>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. 👍 Still reviewing though, need to understand what we ware changing here.

@antiochp
Copy link
Member

Testing locally and looks good so far.

antiochp
antiochp approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hashmap hashmap merged commit 2c62111 into mimblewimble:master May 13, 2020
@hashmap hashmap deleted the unwrap-in-lmdb branch May 13, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashmap @antiochp