Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cursive to 0.14 and update backend. #3291

Merged
merged 5 commits into from
Apr 17, 2020
Merged

Update Cursive to 0.14 and update backend. #3291

merged 5 commits into from
Apr 17, 2020

Conversation

quentinlesceller
Copy link
Member

Update Cursive to 0.14.
Use pancurses-backend instead of ncurses-backend:

uses the pancurses library, which forwards calls to ncurses-rs on Linux/macOS or pdcurses-sys on Windows. Requires ncurses to be installed on the system.

I don't think we need the complexity for Windows in the Cargo.toml.

@quentinlesceller
Copy link
Member Author

quentinlesceller commented Apr 9, 2020 •
edited
Loading

Doing some additional tests on Windows.
EDIT: Working well on Windows

antiochp
antiochp approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on non-windows. Can't speak for windows.
👍 from me.

@quentinlesceller quentinlesceller merged commit 4024ee3 into mimblewimble:master Apr 17, 2020
@quentinlesceller quentinlesceller deleted the ncursesw branch April 17, 2020 19:41
@antiochp antiochp mentioned this pull request Jun 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

@jaspervdm jaspervdm Awaiting requested review from jaspervdm

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentinlesceller @antiochp