-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update seed.rs add seed-node #3282
Conversation
added mainnet-seed.grinnode.live
Update seed.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can someone remind me how our seeds works? These are just treated as regular nodes right?
Is my understanding correct here?
- On startup if we have too few peers then we connect to the seeds.
- These in turn send us lists of their peers (we stay connected to initial seeds as regular peers).
- And all of this is done via ip addresses, resolved one-time during startup when parsing the seeds in the config file.
So there is no situation where we associate a peer with a dns name and end up hitting multiple peers (behind the round robin DNS) without realising we are doing this.
I don't believe this is an issue here - but just want to be sure.
Follow up question - if we use round-robin here with a single DNS name resolving to multiple ip addresses. Is this actually giving us any benefits in terms of high-availability? We're going to just resolve it once, get one of many ip addresses and try that one (regardless of it being available or not). Does the DNS here handle liveness of the underlying nodes behind the DNS? |
In parts it was my problem, when arguing DNS Round-Robin is a High-Available solution. Which technically it is not.
No, as we do not correlate the "liveness" of an IP address and add or delete it to the A-Records. Based on what I did read on the documentation, all Seed-Nodes are only normal Grin-Nodes. We can always roll back to only one IP address or substitute the IP address with the HA-IP address. Lastly as I was checking all Seed-Nodes , a couple of them where down, this was my motivation to open this pull request. |
@MCM-Mike thanks for the answers. Just to be clear, this was not in any way a criticism of what you are doing here. I just wanted to make sure I understood how the grin node was going to handle and respond to a single "seed" that resolved to multiple underlying grin nodes. I'm 👍 on adding an additional seed here. Particularly one that is likely going to be at least as reliable as the existing seeds, if not more so. |
disabled #seeds = ["mainnet-seed.grinnode.live:3414"] due to mimblewimble/grin#3282 we are now part of core DNS seed
added mainnet-seed.grinnode.live
By using DNS Round-Robin (3 nodes) on mainnet-seed.grinnode.live we can provide a high-available seed-node.
name: Pull Request
about: Pull Request checklist
title: ''
labels: ''
assignees: ''
If your PR is a work in progress, please feel free to create it and include a [WIP] tag in the PR name. We encourage everyone to PR early and often so that other developers know what you're working on.
Before submitting your PR for final review, please ensure that it: