Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our original implementation panic'd if the hex string was an odd number of characters.This is bad as we use
from_hex()
when parsing various external ids and hashes.Edit: We prevented the panic via the janky QQQ parse code (see below). So this PR just cleans it up and adds some better test coverage.
let err = ("QQQ").parse::<u64>();
from_hex()
now takes a string slice rather than a StringThis was previously happening if the hex string had an odd number of characters -
Edit: There was an edge case where it panic'd. If the hex string was empty -