Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update croaring #3233

Merged
merged 1 commit into from
Feb 21, 2020
Merged

Update croaring #3233

merged 1 commit into from
Feb 21, 2020

Conversation

quentinlesceller
Copy link
Member

Let's see if it fix the CI issues.

@antiochp
Copy link
Member

🙈

antiochp
antiochp reviewed Feb 18, 2020
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍
I'd like to spend some time testing this locally, just to be confident croaring bitmap serialization has not changed in some unexpected way or anything.
Will try and get to this tomorrow.

@antiochp antiochp added this to the 3.1.0 milestone Feb 18, 2020
@antiochp
Copy link
Member

Testing this right now.

@antiochp
Copy link
Member

Might be worth just going through the updates again to resolve the conflicts, Cargo.lock is kind of a pain to do manually.

@quentinlesceller
Copy link
Member Author

Should be good now @antiochp

antiochp
antiochp approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lets get this merged in once tests pass.

@antiochp antiochp mentioned this pull request Feb 21, 2020
Merged
@antiochp antiochp merged commit ef853ae into mimblewimble:master Feb 21, 2020
@quentinlesceller quentinlesceller deleted the croaring branch February 21, 2020 16:15
@antiochp antiochp mentioned this pull request Feb 24, 2020
Closed
@quentinlesceller quentinlesceller mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@quentinlesceller @antiochp