Cleanup output pos idx #3227
Merged
Cleanup output pos idx #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup unused migration code consolidate use of output_pos index
antiochp
force-pushed
the
cleanup_output_pos_idx
branch
from
de29c50 to
8490dc5
Compare
quentinlesceller
approved these changes
Feb 14, 2020
| @@ -32,8 +32,7 @@ const BLOCK_HEADER_PREFIX: u8 = b'h'; | |||
| const BLOCK_PREFIX: u8 = b'b'; | |||
| const HEAD_PREFIX: u8 = b'H'; | |||
| const TAIL_PREFIX: u8 = b'T'; | |||
| const COMMIT_POS_PREFIX: u8 = b'c'; | |||
| const COMMIT_POS_HGT_PREFIX: u8 = b'p'; | |||
| const OUTPUT_POS_PREFIX: u8 = b'p'; | |||
There was a problem hiding this comment.
👍 for changing the name
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3226.
We have two indices in the db -
The original
COMMIT_POS_PREFIX(pos only) was replaced withCOMMIT_POS_HGT_PREFIX(pos and height) and a migration process was used to convert from one to the other.Now all nodes are on
3.0.0this migration is no longer required and the old legacy index can be safely removed.Also took the opportunity to rename it to
OUTPUT_POS_PREFIXto make it clearer this index is specific to the output MMR.Refactored
get_output_pos()for less code duplication withget_output_pos_height().