Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less cloning and pattern simplifications #3216

Merged
merged 8 commits into from
Feb 5, 2020
Merged

Less cloning and pattern simplifications #3216

merged 8 commits into from
Feb 5, 2020

Conversation

quentinlesceller
Copy link
Member

Relatively large PR.

  • Reduce the number of cloning that we do.
  • Replace !format by to_string() when possible.
  • Remove needless return and variable allocation.
  • Other simplifications

jaspervdm
jaspervdm reviewed Feb 1, 2020
View reviewed changes
Copy link
Contributor

@jaspervdm jaspervdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Couple of small comments.

chain/src/txhashset/txhashset.rs Outdated Show resolved Hide resolved
chain/src/txhashset/txhashset.rs Outdated Show resolved Hide resolved
antiochp
antiochp reviewed Feb 4, 2020
View reviewed changes
core/src/core/pmmr/pmmr.rs Outdated Show resolved Hide resolved
antiochp
antiochp reviewed Feb 4, 2020
View reviewed changes
core/src/libtx/proof.rs Outdated Show resolved Hide resolved
antiochp
antiochp reviewed Feb 4, 2020
View reviewed changes
keychain/src/mnemonic.rs Outdated Show resolved Hide resolved
antiochp
antiochp reviewed Feb 4, 2020
View reviewed changes
util/src/rate_counter.rs Outdated Show resolved Hide resolved
antiochp
antiochp approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
A couple of minor comments, but looks good to me!

@quentinlesceller
Copy link
Member Author

@antiochp updated. See https://github.com/mimblewimble/grin/pull/3216/files#diff-cba101f43397c905b40c554acc3f2c05R107 for comment about unwrap_or_else and this particular function.

antiochp
antiochp reviewed Feb 4, 2020
View reviewed changes
util/src/rate_counter.rs Outdated Show resolved Hide resolved
@quentinlesceller quentinlesceller merged commit c4e6971 into mimblewimble:master Feb 5, 2020
@quentinlesceller quentinlesceller deleted the fix branch February 5, 2020 16:02
@quentinlesceller quentinlesceller mentioned this pull request Feb 14, 2020
Closed
@antiochp antiochp mentioned this pull request Feb 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

@jaspervdm jaspervdm jaspervdm left review comments

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quentinlesceller @jaspervdm @antiochp