Removed binary blob: localhost+1.p12. #3189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Removed binary blob: localhost+1.p12.
about: See issue: #3188
A binary blob exists in Grin
The current Grim implementation includes a binary blob: https://github.com/mimblewimble/grin/blob/master/api/tests/localhost%2B1.p12
Binary blobs harm Grin
Binary blobs harm open source projects because they take agency away from users and developers by obscuring the operations and goings-on of the software project.
Effects of removal
Removing the binary blob does not appear to break building the Grin implementation. Cargo build, test, and run all come back clean.
Floonet
I have not tested this PR against floonet.