Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed binary blob: localhost+1.p12. #3189

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Removed binary blob: localhost+1.p12. #3189

merged 1 commit into from
Jan 15, 2020

Conversation

mplsgrant
Copy link
Contributor


name: Removed binary blob: localhost+1.p12.
about: See issue: #3188

A binary blob exists in Grin
The current Grim implementation includes a binary blob: https://github.com/mimblewimble/grin/blob/master/api/tests/localhost%2B1.p12

Binary blobs harm Grin
Binary blobs harm open source projects because they take agency away from users and developers by obscuring the operations and goings-on of the software project.

Effects of removal
Removing the binary blob does not appear to break building the Grin implementation. Cargo build, test, and run all come back clean.

running 4 tests
test tui::table::test::test_set_items_preserves_order ... ok
test tui::status::test_status_txhashset_rproofs ... ok
test tui::status::test_status_txhashset_kernels ... ok
test tui::table::test::test_set_items_preserves_selected_item ... ok

test result: ok. 4 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

Floonet
I have not tested this PR against floonet.

@ghost
Copy link

ghost commented Jan 15, 2020

I think the reason no tests fail is because the test case is ignored: https://github.com/mimblewimble/grin/blob/master/api/tests/rest.rs#L87 either way that test case advises to retrieve your own certificates and the test case fails if you remove the ignore whether or not the file is present.

"tests/fullchain.pem".to_string(),
"tests/privkey.pem".to_string(),

@hashmap
Copy link
Contributor

hashmap commented Jan 15, 2020

Thanks for your contibution!
@cadwgan0 is right, the test is disabled because it requires an extra setup, this file was needed to get tests at least compile but it's not the case anymore.

@mplsgrant unrelated hint - you need to run cargo test --all or go to each crate and run tests there, in your output you run tests only for grin

@hashmap hashmap merged commit 0ad2513 into mimblewimble:master Jan 15, 2020
@antiochp antiochp mentioned this pull request Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants