Build block header from pre pow data and proof #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinlesceller
approved these changes
Jan 21, 2020
antiochp
reviewed
Jan 22, 2020
antiochp
reviewed
Jan 23, 2020
| ) -> Result<Self, Error> { | ||
| // Convert hex pre pow string | ||
| let mut header_bytes = from_hex(pre_pow) | ||
| .map_err(|e| Error::Serialization(ser::Error::HexError(e.to_string())))?; |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple notes about the changes:
Stringalthough there is no need for it to be mutable in this function.&strsince that does not need to be mutable either as it is just reading (that function is the main reason I kept as String, because it would just be converted back to a String anyway)