Refactor to pass batch around explicitly #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
changed the title
antiochp
changed the title
…e extension. We would like to be able to pass an extension around and potentially clone it.
antiochp
force-pushed
the
pass_batch_around
branch
from
23b3ad5 to
01eeddd
Compare
quentinlesceller
approved these changes
Jan 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to pass
batcharound explicitly rather than maintaining it on the extension.This provides a cleaner separation between the PMMR backend and the lmdb database batch.
We would like to be able to pass an extension around and potentially clone it without needing to be concerned with the db batch.