tests: split consensus tests into separate files for each chain type … #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to avoid non deterministic behaviour due to shared global state in global.rs
quentinlesceller
requested changes
Jan 21, 2020
There was a problem hiding this comment.
Looking very good. I think we could keep a consensus.rs file around for tests such as this one https://github.com/mimblewimble/grin/pull/3178/files#diff-0e42d6d281665de4ca0d262d0db8550eR575. I think fixing the merge conflict will lead you to this.
|
I fixed the conflicts. What exactly would you suggest to put in consensus.rs? As far as I can see it would be empty (there are no consensus integration tests that don't call global::set_mining_mode()). |
quentinlesceller
approved these changes
Jan 27, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHAIN_TYPE in global.rs is shared global state and we have multiple tests that modify this state through global::set_mining_mode(). Each Rust test target (file) is run with multiple threads, so the tests with shared state cannot be sure that the state is correct (chain_type could be modified by another test thread) causing intermittent failures.
I suggest we separate tests into different files depending on the chain type they need as I have done in this change. That way we can keep the global state, which is convenient and still run tests for the same chain type in parallel.