Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove error serialization/deserialization" #3151

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Revert "Remove error serialization/deserialization" #3151

merged 1 commit into from
Nov 29, 2019

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Nov 29, 2019

Reverts #3110

yeastplume
yeastplume approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@yeastplume yeastplume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed it earlier, but this is actually needed by the wallet so it can serialize errors into JSON in the JSON-RPC API

@yeastplume yeastplume merged commit ba9cdd3 into master Nov 29, 2019
@antiochp antiochp deleted the revert-3110-error-serialization branch January 6, 2020 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeastplume yeastplume yeastplume approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashmap @yeastplume