cleanup HeaderVersion::default() #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
force-pushed
the
default_header_version
branch
from
10fcd47 to
4eec76e
Compare
antiochp
changed the title
"empty" block can safely have verion 0 as it needs to be set later
antiochp
force-pushed
the
default_header_version
branch
from
c914050 to
2b4adda
Compare
yeastplume
approved these changes
Dec 2, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HF2 changes removed our usage of a "default" header version (#3136).
The concept of a "default" header version is a little ambiguous as the valid version is dependent on block height. So this PR just makes it explicit everywhere and gets rid of the
Defaultimpl.We can now simply set the version to 0 on a default block, as we set it later to the required valid version when we set the height.Edit: We actually use the "default" header version when building the mainnet genesis hash on startup (same for floonet). So leaving this as
1in the block header default constructor.