Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use saturating_sub() to avoid a negative value causing an overflow panic (tui logs) #3139

Merged
merged 1 commit into from
Nov 26, 2019
Merged

use saturating_sub() to avoid a negative value causing an overflow panic (tui logs) #3139

merged 1 commit into from
Nov 26, 2019

Conversation

antiochp
Copy link
Member

@antiochp antiochp commented Nov 26, 2019 •
edited
Loading

Resolves #3138

Q) What's actually causing this though?

@antiochp antiochp added the bug label Nov 26, 2019
quentinlesceller
quentinlesceller approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing @JosephGoulden might know the answer.

@antiochp antiochp merged commit dcfcd3e into mimblewimble:master Nov 26, 2019
@antiochp antiochp deleted the fix_tui_logs_overflow branch November 26, 2019 19:05
@antiochp antiochp added this to the 3.0.0 milestone Dec 11, 2019
@antiochp antiochp mentioned this pull request Dec 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

tui logs tab causing panic
2 participants
@antiochp @quentinlesceller