Remove Writeable impl for [u8; 4] #3132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
changed the title
antiochp
force-pushed
the
writeable_for_u8_4
branch
from
a20cf8a to
e0f932e
Compare
antiochp
changed the title
quentinlesceller
added a commit
to quentinlesceller/grin
that referenced
this pull request
Feb 5, 2020
This reverts commit 5e1fe44.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impl of the
Writeabletrait feels wrong and as far as I can tell its not actively used by anything.Note we call
write_bytes()here and notwrite_fixed_bytes().This will prefix the bytes themselves with a u64 to represent the size in bytes (which in this case is always a fixed 4 bytes). So we would be serializing 4 bytes as 8 bytes + 4 bytes each time.
The only place I see
[u8; 4]being used is in the keychain crate forExtendedPrivKeyandFingerprintbut I do not see these usingReadable/Writeabletraits anywhere.@yeastplume Do you reckon this is safe to cleanup?
Is there anywhere we may be using this?