feat: allow DNS names in peers/seeds list and resolve them #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashmap
reviewed
Nov 19, 2019
JosephGoulden
force-pushed
the
dns-seeds
branch
from
1d5aa8f to
77703e8
Compare
quentinlesceller
requested changes
Dec 4, 2019
|
We should hold off merging this until after 3.0.0 is released. This is potentially wide-reaching in terms of its effect on the network as a whole. @JosephGoulden Can you add something to the top of the PR description to remind us? |
quentinlesceller
requested changes
Jan 21, 2020
quentinlesceller
approved these changes
Jan 28, 2020
|
3.0.0 has long been released. Should we get this merged now? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is for after 3.0 release/branch
Enhancement to allow DNS names in the config for seeds, allow/deny/preferred peers and dandelion peer. Fixes #3120
Port is always required otherwise a panic will occur when attempting to parse the domain name.
There is a slight confusion caused by the seed type of DNSSeed, as the List type can now contain DNS seeds as well. Maybe DNSSeed could be deprecated in favour of DefaultSeed.
I've manually tested adding DNS names peers list and works as expected.