Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MimbleWimble by Mimblewimble #3118

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Replace MimbleWimble by Mimblewimble #3118

merged 3 commits into from
Nov 19, 2019

Conversation

quentinlesceller
Copy link
Member

Replace MimbleWimble by Mimblewimble.

antiochp
antiochp reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I prefer the original MimbleWimble.

@quentinlesceller quentinlesceller mentioned this pull request Nov 14, 2019
Merged
@quentinlesceller
Copy link
Member Author

quentinlesceller commented Nov 14, 2019 •
edited
Loading

The thing is MimbleWimble is incorrect for three reasons:

I believe this typo was introduced in this talk title (only on Youtube though) at SF Bitcoin Dev https://www.youtube.com/watch?v=aHTRlbCaUyM

@antiochp
Copy link
Member

Hmm Still prefer MimbleWimble personally but reasonably convinced that this change is worth doing for consistency with the original paper etc.

👍

antiochp
antiochp approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do it.

@antiochp antiochp merged commit 04e7d30 into mimblewimble:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentinlesceller @antiochp