Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of try! macro, use ? instead #3097

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Remove usage of try! macro, use ? instead #3097

merged 1 commit into from
Oct 21, 2019

Conversation

hashmap
Copy link
Contributor

@hashmap hashmap commented Oct 21, 2019

We converted the major part of the code a while ago, but some occurences were left. It's a compiler warning on nightly already.

@hashmap
Remove usage of try! macro, use ? instead
f2468db 
We converted the major part of the code a while ago, but some occurences were left. It's a compiler warning on nightly already.
@hashmap hashmap added the task label Oct 21, 2019
@quentinlesceller quentinlesceller merged commit 8a7da89 into mimblewimble:master Oct 21, 2019
antiochp
antiochp reviewed Oct 22, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp left review comments

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hashmap @quentinlesceller @antiochp