skip hydrate if missing kernels, just request full block #3090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing a compact block if we have missing kernels after looking in the txpool then we know hydration will fail (we do not have all the necessary txs).
We were waiting for the hydration step to fail. Hydration was guaranteed to fail here as we did not have the necessary txs in the txpool to hydrate the block.
We should just check if we have anything missing, stop processing and go request the full block.
The "hooks" will now only fire if our compact block can be successfully hydrated. We no longer (incorrectly) state we received a block when if fact we have not yet received it in its valid form -