node incorrectly suppresses header broadcast for full blocks (after failing to hydrate a compact block) #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
changed the title
hashmap
approved these changes
Oct 8, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3087.
Related #2349.
If we receive a compact block but cannot successfully hydrate it based on the txs in the txpool then we will fallback to requesting the full block. In this situation we incorrectly suppress block broadcast to our peers.
It is not sufficient to simply track which blocks we request from a peer (suppressing header broadcast if we requested the block).
We need to track the originating
opts=SYNC|NONEfor each requested block.We then only suppress the broadcast for blocks received after requesting them as part of sync.
Blocks received as part of compact block hydration should be broadcast normally.
This surfaced because we also suppress the "block_received" callback log msgs and we were not logging some compact blocks after hydration failed.