Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version for 2.1.0 dev (still on master) #3050

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

antiochp
Copy link
Member

Bumps the crate versions to reflect upcoming release 2.1.0.

This is on master so I bumped the version to 2.1.0-dev.1 which I think makes more sense than the 2.0.1-beta.1 currently in place.

Proposing we stick with -dev suffix until we cut the beta release when we can bump the versioning again to 2.1.0-beta.1 on the 2.1.0 branch itself.

I'd like to be able to visually inspect peer user agents in the TUI and have a rough idea of which are running against a recent build from master.

I toyed with the idea of including the build date or timestamp in the user agent when built from master. But there are some privacy and anonymity concerns involved there.

@antiochp antiochp added the task label Sep 19, 2019
@antiochp antiochp added this to the 2.1.0 milestone Sep 19, 2019
@antiochp antiochp force-pushed the 2_1_0_dev_user_agent branch from 7274900 to 639425d Compare September 19, 2019 13:40
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Also we probably don't need to know on which commit exactly connected peers are (+privacy as you said). So I'm okay with the dev in the version.

@antiochp antiochp merged commit f3baceb into mimblewimble:master Sep 19, 2019
@antiochp antiochp deleted the 2_1_0_dev_user_agent branch September 19, 2019 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants